Update to Cadence v0.9.2 #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dapperlabs/flow-go#4894
Cadence v0.9.2 now panics with a dedicated error for out-of-bounds array accesses. Previously it relied on Go's bounds check, i.e. the error was a Go runtime error.
Non-Go runtime errors are bubbled to the host environment, as they indicate an implementation error, non-Go (Cadence) errors are returned as errors: https://github.com/onflow/cadence/blob/0a889feb15fb738b83924d372677cf8720cb8706/runtime/interpreter/interpreter.go#L855-L870
This means that nothing else needs to be done in flow-go, other than updating to the latest version.