Verification Node utilizes separation of results and receipts in block Payload #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• added grouping for ExecutionReceiptMeta and unit tests; • added grouping for ExecutionResult and unit tests; • updated Payload to use ExecutionReceiptMetaList and ExecutionResultList • minor refactoring on verifier's assigner.Engine;
AlexHentschel
requested review from
zhangchiqing,
durkmurder and
yhassanzadeh13
Base automatically changed from
yurii/4798-payload-receipts-optimization
to
master
April 8, 2021 13:32
…results # Conflicts: # engine/verification/assigner/engine.go # utils/unittest/fixtures.go
AlexHentschel
changed the title
durkmurder
reviewed
Apr 14, 2021
durkmurder
reviewed
Apr 14, 2021
durkmurder
reviewed
Apr 14, 2021
durkmurder
approved these changes
Apr 14, 2021
zhangchiqing
approved these changes
Apr 14, 2021
yhassanzadeh13
approved these changes
Apr 15, 2021
Co-authored-by: Leo Zhang <zhangchiqing@gmail.com>
Co-authored-by: Leo Zhang <zhangchiqing@gmail.com>
AlexHentschel
deleted the
alex/5397_verifier_processes_incorporated_results
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements https://github.com/dapperlabs/flow-go/issues/5397:
assigner.Engineto utilize separation of results from receipts in block Payloadthere are also some utility logic included in this PR:
ExecutionReceiptMetaand unit testsExecutionResultand unit testsExecutionReceiptMetaListandExecutionResultListpayload.ResultsById()withpayload.Results.Lookup()