Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report additional logs in metrics migration #6024

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Conversation

SupunS
Copy link
Member

@SupunS SupunS commented Jun 3, 2024

No description provided.

@SupunS SupunS self-assigned this Jun 3, 2024
@SupunS
Copy link
Member Author

SupunS commented Jun 3, 2024

cc: @j1010001 I addressed one of the TODOs (i.e: also consider the "contract type" itself for the metrics) which may have caused a discrepancy on the reported number. In case if it didn't solve, the added additional log should give us enough info to narrow down the issue.

@SupunS SupunS marked this pull request as ready for review June 3, 2024 20:24
@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 6 lines in your changes missing coverage. Please review.

Project coverage is 55.85%. Comparing base (50ec918) to head (e1a73de).
Report is 26 commits behind head on master.

Files Patch % Lines
...l/ledger/migrations/migration_metrics_collector.go 57.14% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6024      +/-   ##
==========================================
- Coverage   55.86%   55.85%   -0.02%     
==========================================
  Files        1131     1133       +2     
  Lines       89499    89974     +475     
==========================================
+ Hits        50003    50257     +254     
- Misses      34732    34930     +198     
- Partials     4764     4787      +23     
Flag Coverage Δ
unittests 55.85% <57.14%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SupunS SupunS requested review from a team June 3, 2024 20:24
Copy link
Member

@fxamacker fxamacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I only reviewed general Go programming aspect.

@SupunS SupunS added this pull request to the merge queue Jun 4, 2024
Merged via the queue into master with commit 4ca1a25 Jun 4, 2024
55 checks passed
@SupunS SupunS deleted the supun/migration-stats branch June 4, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants