Transactions signatures that include the transaction domain tag are valid #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4ksio
approved these changes
Apr 13, 2021
psiemens
reviewed
Apr 15, 2021
| @@ -1775,3 +1776,35 @@ func TestBlockContext_ExecuteTransaction_FailingTransactions(t *testing.T) { | |||
| }), | |||
| ) | |||
| } | |||
| func TestSigningWithTags(t *testing.T) { | |||
| t.Run("Signing Transactions without tag works (for now)", newVMTest(). | |||
There was a problem hiding this comment.
Can you add a test case for signing with a tag?
There was a problem hiding this comment.
Actually my process was:
- remove ability to sign without a tag
- make sure all tests pass by adding the tag where necessary (I also used a local version of the SDK that added the tag)
- re-add ability to sign without a tag
So all other tests (that do signing) use a tag (or will use it when the SDK version is updated). That is why I only added a test for explicitly not using it.
Do you still think it makes sense to add an explicit test case for using the tag?
6 tasks
ramtinms
approved these changes
Apr 16, 2021
psiemens
approved these changes
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: https://github.com/dapperlabs/flow-go/issues/5204
Description
Right now transaction message is not prepended with a domain tag before signed. For a period of time we want both 'not prepended' and 'prepended' to be valid. This PR makes that change in flow-go
Changes