Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flow EVM] add uuids to the deposit and withdraw events #6106

Merged
merged 11 commits into from
Jun 21, 2024
Merged

[Flow EVM] add uuids to the deposit and withdraw events #6106

merged 11 commits into from
Jun 21, 2024

Conversation

ramtinms
Copy link
Member

@ramtinms ramtinms commented Jun 16, 2024 •
edited
Loading

closes #6103

@ramtinms ramtinms changed the title add uuids to the deposit and withdraw events [Flow EVM] add uuids to the deposit and withdraw events Jun 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 41.53%. Comparing base (b219b03) to head (f6e3c0c).

Files Patch % Lines
utils/unittest/execution_state.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6106      +/-   ##
==========================================
- Coverage   41.73%   41.53%   -0.20%     
==========================================
  Files        1971     1097     -874     
  Lines      138836    68833   -70003     
==========================================
- Hits        57941    28589   -29352     
+ Misses      74888    37343   -37545     
+ Partials     6007     2901    -3106
Flag Coverage Δ
unittests 41.53% <0.00%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ramtinms ramtinms requested a review from turbolent June 17, 2024 16:11
@ramtinms ramtinms marked this pull request as ready for review June 17, 2024 16:27
turbolent
turbolent approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Just a few minor formatting suggestions

fvm/evm/stdlib/contract.cdc Outdated Show resolved Hide resolved
fvm/evm/stdlib/contract.cdc Outdated Show resolved Hide resolved
fvm/evm/stdlib/contract.cdc Outdated Show resolved Hide resolved
fvm/evm/stdlib/contract.cdc Outdated Show resolved Hide resolved
@turbolent
Copy link
Member

Needs an update of the state commitments

@turbolent turbolent requested a review from a team June 17, 2024 18:50
janezpodhostnik
janezpodhostnik approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@janezpodhostnik janezpodhostnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct me if I a mistaken but this is purely a contract upgrade and can be deployed at any time (on previewnet)

@ramtinms
Copy link
Member Author

Correct

@ramtinms ramtinms enabled auto-merge June 20, 2024 18:07
sisyphusSmiling
sisyphusSmiling approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@sisyphusSmiling sisyphusSmiling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 New event values LGTM

@ramtinms ramtinms added this pull request to the merge queue Jun 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 20, 2024
@ramtinms ramtinms added this pull request to the merge queue Jun 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 20, 2024
@ramtinms ramtinms enabled auto-merge June 21, 2024 03:03
@ramtinms ramtinms added this pull request to the merge queue Jun 21, 2024
Merged via the queue into master with commit 6db1bfd Jun 21, 2024
55 checks passed
@ramtinms ramtinms deleted the ramtin/6103-add-uuids-to-deposit-and-withdraw-events branch June 21, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbolent turbolent turbolent approved these changes

@janezpodhostnik janezpodhostnik janezpodhostnik approved these changes

@sisyphusSmiling sisyphusSmiling sisyphusSmiling approved these changes

@zhangchiqing zhangchiqing Awaiting requested review from zhangchiqing

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Flow EVM] update token deposit and withdrawn events to include the uuid of vaults
5 participants
@ramtinms @codecov-commenter @turbolent @janezpodhostnik @sisyphusSmiling