Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Fix flaky blocks streaming integration test #6125

Merged
merged 6 commits into from
Jun 21, 2024
Merged

[CI] Fix flaky blocks streaming integration test #6125

merged 6 commits into from
Jun 21, 2024

Conversation

UlyanaAndrukhiv
Copy link
Contributor

Closes: #6083

Context

  • Fixed the SubscribeBlocksFromLatest test by removing the logic where the test waits for the requested number of sealed blocks, as that affects the AN's latest block. This can cause a discrepancy between the latest blocks of AN and ON.
  • Added a check during ON block tracking to include only the blocks that were already tracked from the AN subscription. This ensures that we compare the expected count of blocks.

@Guitarheroua Guitarheroua added this pull request to the merge queue Jun 21, 2024
Merged via the queue into onflow:master with commit 1788144 Jun 21, 2024
55 checks passed
@Guitarheroua Guitarheroua deleted the UlyanaAndrukhiv/6083-flaky-blocks-streaming-integration-test branch June 21, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Guitarheroua Guitarheroua Guitarheroua approved these changes

@peterargue peterargue peterargue approved these changes

Assignees

@UlyanaAndrukhiv UlyanaAndrukhiv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] Fix flaky blocks streaming integration test
3 participants
@UlyanaAndrukhiv @Guitarheroua @peterargue