adding logging around libp2p one-to-one stream management #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishalchangrani
commented
Jun 4, 2021
| @@ -277,13 +277,13 @@ func (m *Middleware) SendDirect(msg *message.Message, targetID flow.Identifier) | |||
| // flush the stream | |||
| err = bufw.Flush() | |||
| if err != nil { | |||
| return fmt.Errorf("failed to flush stream for %s: %w", targetID.String(), err) | |||
| return fmt.Errorf("failed to flush stream for %s: %w", targetIdentity.String(), err) | |||
There was a problem hiding this comment.
identity gives IP address in addition to node id.
vishalchangrani
commented
Jun 4, 2021
| @@ -79,7 +79,7 @@ func (rc *readConnection) receiveLoop(wg *sync.WaitGroup) { | |||
| rc.closeStream() | |||
| return | |||
| } | |||
| rc.log.Error().Err(err) | |||
| rc.log.Error().Err(err).Msg("failed to read message") | |||
There was a problem hiding this comment.
logger won't print log if there is no Msg field.
vishalchangrani
commented
Jun 7, 2021
| @@ -120,12 +118,3 @@ func (rc *readConnection) resetStream() { | |||
| rc.log.Error().Err(err).Msg("failed to reset stream") | |||
| } | |||
| } | |||
|
|
|||
| func streamLogger(log zerolog.Logger, stream libp2pnetwork.Stream) zerolog.Logger { | |||
There was a problem hiding this comment.
moved this to libp2pUtils.go
zhangchiqing
approved these changes
Jun 7, 2021
Kay-Zee
approved these changes
Jun 8, 2021
Codecov Report
@@ Coverage Diff @@
## master #785 +/- ##
==========================================
- Coverage 56.42% 56.42% -0.01%
==========================================
Files 423 423
Lines 24793 24789 -4
==========================================
- Hits 13990 13987 -3
+ Misses 8909 8907 -2
- Partials 1894 1895 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help debug the stream reset issue, I have made some minor logging changes.