Problem: when adding an element to the queue, which was already prese… #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt, the queue would dedup the element itself (as it is stored in a map). However, it would duplicate the children reference for the parent (as this is a list). Fix: • check if element to be added is already present in the queue and NoOp in this case. • extended goDoc on return value updated mempool Queue method Attach: • added consistency check for partially overlapping queues • extended godoc • included unit test
AlexHentschel
added this to the Sprint 28 - Post Beta Mainnet - Part 12 [Nov 30-Dec 11] milestone
Kay-Zee
approved these changes
Oct 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stability improvements for
mempool.Queuemainnet1-oct17-patch)Summary of significant changes:
updated method
Queue.TryAdd:When adding an element to the queue, which was already present, the queue would dedup the element itself (as it is stored in a map). However, it would not duplicate the
Childrenreference for the element's parent (as this is a list).updated method
Queue.Attach: