Epoch service events #799
Merged
Epoch service events #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanschalm
approved these changes
Jun 8, 2021
yhassanzadeh13
approved these changes
Jun 8, 2021
| } | ||
|
|
||
| // extract simple fields | ||
| counter, ok := cdcEvent.Fields[0].(cadence.UInt64) |
There was a problem hiding this comment.
Would be more maintainable and less error prone to have these indices defined as constants:
const (
counterFieldIndex int = iota
participantsIndex
// etc
)
Then we get to this function, we can have the indices replaced by predefined constants:
counter, ok := cdcEvent.Fields[counterFieldIndex].(cadence.UInt64)
| return nil, invalidCadenceTypeError("cluster", cdcCluster, cadence.Struct{}) | ||
| } | ||
|
|
||
| expectedFields := 2 |
There was a problem hiding this comment.
Similar suggestion for these embedded values (i.e., constant aliasing)
Codecov Report
@@ Coverage Diff @@
## master #799 +/- ##
==========================================
+ Coverage 56.49% 56.56% +0.06%
==========================================
Files 427 429 +2
Lines 25133 25461 +328
==========================================
+ Hits 14199 14402 +203
- Misses 9013 9082 +69
- Partials 1921 1977 +56
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @jordanschalm - this is a cherry pick from epoch branch which contains expanding on service events which is useful for verification of them in upcoming PRs.
Epoch branch is a big changeset and this subset is self-contained so we agreed to extract it here.