Storage fees: storage limiter #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w/flow-go into janez/storage-fees-storage-limiter
…w/flow-go into janez/storage-fees-storage-limiter
janezpodhostnik
added this to the Sprint 28 - Post Beta Mainnet - Part 12 [Dec 07-Dec 18] milestone
…w/flow-go into janez/storage-fees-storage-limiter
…w/flow-go into janez/storage-fees-storage-limiter
…w/flow-go into janez/storage-fees-storage-limiter
psiemens
approved these changes
Nov 4, 2020
|
|
||
| type TransactionStorageLimiter struct{} | ||
|
|
||
| func NewTransactionStorageLimiter() *TransactionStorageLimiter { |
| } | ||
| } | ||
|
|
||
| func newMockLedger(updatedKeys []string, ownerKeyStorageValue []OwnerKeyValue) MockLedger { |
There was a problem hiding this comment.
Would it be possible to use MapLedger in place of this mock? I think you could keep this helper function to seed the ledger state -- I'm just not sure you need to define an extra data structure
There was a problem hiding this comment.
I wanted to check how many times I access the ledger get function. I don't think I can do that part with the MapLedger. I could remove those tests, since they are only testing that storage capacity checking is done once per account.
ramtinms
approved these changes
Nov 5, 2020
…w/flow-go into janez/storage-fees-storage-limiter
…w/flow-go into janez/storage-fees-storage-limiter
…w/flow-go into janez/storage-fees-storage-limiter
Base automatically changed from
janez/storage-fees-storage-updates
to
feature/storage-fees
November 17, 2020 15:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FLIP reference: onflow/flow#99
task reference: https://github.com/dapperlabs/flow-go/issues/4935
add storage limit checking to the transaction pipeline