And non relic bls stubs #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarakby
approved these changes
Jun 8, 2021
crypto/bls_non_relic.go
Outdated
| // Temporary stubs for BLS implementation. This is used only when the crypto library is built without the relic tag. | ||
| // This is currently just the emulator. | ||
|
|
||
| const blsNotSupported = "BLSKMAC not supported when flow-go is build without relic" |
There was a problem hiding this comment.
Suggested change
| const blsNotSupported = "BLSKMAC not supported when flow-go is build without relic" | |
| const blsNotSupported = "BLS and KMAC not supported when flow-go is built without relic" |
tarakby
reviewed
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The emulator is built without a relic tag. Without the changes here the build of
flow-go/cryptofails without a relic tag. This makes the build pass but the emulator wont be able to use BLS which will be addressed later.@tarakby originally I wanted to change the CI to include a lint step without a relic tag, but linting the
cryptofolder produces lint warnings. I did not feel those needed to be addressed, as this is probably a temporary solution. So to confirm that this work I prepared this draft PR in the emulator, that passes CI.