Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto Cadence Update: Disable the wasmtime VM for now #812

Merged
merged 1 commit into from Jun 10, 2021

Conversation

turbolent
Copy link
Member

Auto generated PR to update Cadence version.

References: onflow/cadence#991

@codecov-commenter
Copy link

Codecov Report

Merging #812 (c70d17e) into master (2f7d0df) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #812      +/-   ##
==========================================
- Coverage   56.48%   56.42%   -0.07%     
==========================================
  Files         427      427              
  Lines       24975    24975              
==========================================
- Hits        14108    14091      -17     
- Misses       8967     8978      +11     
- Partials     1900     1906       +6     
Flag Coverage Δ
unittests 56.42% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
module/mempool/epochs/transactions.go 94.73% <0.00%> (-5.27%) ⬇️
engine/execution/ingestion/engine.go 52.19% <0.00%> (-2.68%) ⬇️
network/p2p/ping.go 54.34% <0.00%> (-2.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f7d0df...c70d17e. Read the comment docs.

@janezpodhostnik
Copy link
Contributor

I'm not sure I understand how this reduces code coverage...

@turbolent
Copy link
Member Author

I think the tests are not deterministic and cover different parts

@turbolent turbolent merged commit 3619e5c into master Jun 10, 2021
@turbolent turbolent deleted the auto-cadence-upgrade/bastian/disable-wasmtime-vm branch June 10, 2021 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants