Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Verification] Logging block height on chunk processing pipeline #856

Merged

Conversation

yhassanzadeh13
Copy link
Contributor

@yhassanzadeh13 yhassanzadeh13 commented Jun 17, 2021

This PR adds block height to the logs on the processing pipeline of chunks in the verification node.

@yhassanzadeh13 yhassanzadeh13 changed the title Yahya/logging block height in verification node [Verification] Logging block height on chunk processing pipeline Jun 17, 2021
@yhassanzadeh13 yhassanzadeh13 marked this pull request as ready for review June 17, 2021 18:31
@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2021

Codecov Report

Merging #856 (1f4f0b1) into master (8bb7d21) will increase coverage by 0.02%.
The diff coverage is 82.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #856      +/-   ##
==========================================
+ Coverage   56.50%   56.53%   +0.02%     
==========================================
  Files         427      427              
  Lines       25116    25129      +13     
==========================================
+ Hits        14192    14206      +14     
+ Misses       9006     9005       -1     
  Partials     1918     1918              
Flag Coverage Δ
unittests 56.53% <82.35%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
engine/verification/fetcher/engine.go 77.73% <76.92%> (+1.22%) ⬆️
engine/verification/assigner/engine.go 79.71% <100.00%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bb7d21...1f4f0b1. Read the comment docs.

Copy link
Member

@zhangchiqing zhangchiqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Could also log the height here

@yhassanzadeh13 yhassanzadeh13 merged commit f45a9bf into master Jun 17, 2021
@yhassanzadeh13 yhassanzadeh13 deleted the yahya/logging-block-height-in-verification-node branch June 17, 2021 22:17
huitseeker pushed a commit to huitseeker/flow-go that referenced this pull request Oct 12, 2021
…low#856)

* adds block height to assigner engine logs

* adds block height to fetcher engine

* adds block height to chunk status

* refactors chunk status block type

* complements block height logging in fetcher

* adds block height for sealed chunks logging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants