Update README installation instructions #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Had a bit of trouble with the initial install few days ago, added a step to the README to make the environment variable setup more explicit.
Codecov Report
@@ Coverage Diff @@
## master #895 +/- ##
==========================================
+ Coverage 56.89% 56.91% +0.02%
==========================================
Files 429 429
Lines 25635 25635
==========================================
+ Hits 14584 14591 +7
+ Misses 9079 9074 -5
+ Partials 1972 1970 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Adding more reviewers (you need a minimum of two to merge) |
vishalchangrani
approved these changes
Jun 24, 2021
jordanschalm
approved these changes
Jun 24, 2021
| - Make sure the `GOPATH` and `GOBIN` environment variables are set, and `GOBIN` is added to your path: | ||
|
|
||
| ```bash | ||
| export GOPATH=$(go env GOPATH) |
There was a problem hiding this comment.
This will work the first run, but in general I think they will need to add this to their shell profile so it is persisted. Maybe we can add a note to do that as well and link to the docs
Co-authored-by: Vishal <1117327+vishalchangrani@users.noreply.github.com>
…to smnzhu-patch-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had a bit of trouble with the initial install few days ago, added a step to the README to make the environment variable setup more explicit.