[FVM] refactor5- simplify storage limit checker code #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramtinms
changed the title
ramtinms
changed the title
janezpodhostnik
approved these changes
Jul 13, 2021
| @@ -186,6 +186,10 @@ func (e *ScriptEnv) ValueExists(owner, key []byte) (exists bool, err error) { | |||
| return len(v) > 0, nil | |||
| } | |||
|
|
|||
| func (e *ScriptEnv) AccountExists(address common.Address) (exists bool, err error) { | |||
There was a problem hiding this comment.
I don't see this being used anywhere, or did I miss something.
There was a problem hiding this comment.
not used anywhere yet, but I need it for the next PR.
Kay-Zee
approved these changes
Jul 13, 2021
|
|
||
| // does it exist? |
There was a problem hiding this comment.
Do we no longer need to check for existence?
There was a problem hiding this comment.
no need to check existence accounts that are passed are already checked and if accounts not exist it would return zero capacity so it errors out.
m4ksio
approved these changes
Jul 23, 2021
| func (e *ScriptEnv) EmitEvent(event cadence.Event) error { | ||
| return errors.NewOperationNotSupportedError("EmitEvent") | ||
| } | ||
|
|
||
| func (e *ScriptEnv) Events() []flow.Event { | ||
| return []flow.Event{} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: