Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VER] Patch verification integration code #952

Merged
merged 2 commits into from Jul 13, 2021

Conversation

ramtinms
Copy link
Member

@ramtinms ramtinms commented Jul 12, 2021

This PR :

  • patches the test logic to create fixtures for integration tests
  • fixes the issue in the chunk verifier on what tx index to use for system chunk transaction

@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2021

Codecov Report

Merging #952 (b728759) into master (98dc4aa) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #952   +/-   ##
=======================================
  Coverage   54.92%   54.92%           
=======================================
  Files         277      277           
  Lines       18342    18342           
=======================================
  Hits        10075    10075           
  Misses       6903     6903           
  Partials     1364     1364           
Flag Coverage Δ
unittests 54.92% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
engine/execution/convert.go 88.88% <100.00%> (ø)
module/chunks/chunkVerifier.go 64.76% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98dc4aa...b728759. Read the comment docs.

@ramtinms ramtinms changed the title [WIP] fix verification test issue Fix verification test issue Jul 13, 2021
@ramtinms ramtinms changed the title Fix verification test issue [VER] Patch verification integration code Jul 13, 2021
@ramtinms ramtinms merged commit cbfec5b into master Jul 13, 2021
@ramtinms ramtinms deleted the ramtin/port-verification-test-fixes branch July 13, 2021 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants