Yahya/5005-fix-flakey-libp2p-test

crypto/bls_test.go

@@ -128,7 +128,7 @@ func TestAggregateSignatures(t *testing.T) {
 	sks := make([]PrivateKey, 0, sigsNum)
 	pks := make([]PublicKey, 0, sigsNum)
 	seed := make([]byte, KeyGenSeedMinLenBLSBLS12381)
-	var aggSig,expectedSig Signature
+	var aggSig, expectedSig Signature
 
 	// create the signatures
 	for i := 0; i < sigsNum; i++ {
@@ -161,7 +161,6 @@ func TestAggregateSignatures(t *testing.T) {
 			fmt.Sprintf("Verification of %s failed, signature should be %s private keys are %s, input is %x",
 				aggSig, expectedSig, sks, input))
 	})
-
 
 	// check if one the signatures is not correct
 	t.Run("one invalid signatures", func(t *testing.T) {
@@ -182,7 +181,6 @@ func TestAggregateSignatures(t *testing.T) {
 		sigs[randomIndex], err = sks[randomIndex].Sign(input, kmac)
 	})
 
-
 	// check if one the public keys is not correct
 	t.Run("one invalid public key", func(t *testing.T) {
 		randomIndex := mrand.Intn(sigsNum)
@@ -390,10 +388,10 @@ func TestBatchVerify(t *testing.T) {
 	})
 
 	// pick a random number of invalid signatures
-	invalidSigsNum := mrand.Intn(sigsNum-1) + 1 
-	// generate a random permutation of indices to pick the 
+	invalidSigsNum := mrand.Intn(sigsNum-1) + 1
+	// generate a random permutation of indices to pick the
 	// invalid signatures.
-	indices := make([]int, 0, sigsNum)          
+	indices := make([]int, 0, sigsNum)
 	for i := 0; i < sigsNum; i++ {
 		indices = append(indices, i)
 	}
@@ -425,7 +423,7 @@ func TestBatchVerify(t *testing.T) {
 				sigs[indices[i]] = sigs[indices[i]][:3] // test the short signatures
 			}
 		}
-	
+
 		valid, err := BatchVerifySignaturesOneMessage(pks, sigs, input, kmac)
 		require.NoError(t, err)
 		assert.Equal(t, valid, expectedValid,
@@ -456,7 +454,7 @@ func TestBatchVerify(t *testing.T) {
 		}
 		valid, err := BatchVerifySignaturesOneMessage(pks, sigs, input, nil)
 		require.Error(t, err)
-		
+
 		assert.Equal(t, valid, expectedValid,
 			fmt.Sprintf("verification should fail with incorrect input lenghts, got %v", valid))
 	})
@@ -509,7 +507,7 @@ func BenchmarkBatchVerify(b *testing.B) {
 	// - if all signatures are invalid (valid points in G1):
 	// (2*2*(n-1)) pairings compared to (2*n) pairings for the simple verification.
 	b.Run("unhappy path", func(b *testing.B) {
-			// only one invalid signature
+		// only one invalid signature
 		alterSignature(sigs[sigsNum/2])
 		b.ResetTimer()
 		for i := 0; i < b.N; i++ {

crypto/sign_test_utils.go

@@ -34,13 +34,13 @@ func testGenSignVerify(t *testing.T, salg SigningAlgorithm, halg hash.Hasher) {
 		s, err := sk.Sign(input, halg)
 		require.NoError(t, err)
 		pk := sk.PublicKey()
-		
+
 		// test a valid signature
 		result, err := pk.Verify(s, input, halg)
 		require.NoError(t, err)
 		assert.True(t, result, fmt.Sprintf(
 			"Verification should succeed:\n signature:%s\n message:%x\n private key:%s", s, input, sk))
-		
+
 		// test with a different message
 		input[0] ^= 1
 		result, err = pk.Verify(s, input, halg)
@@ -101,16 +101,16 @@ func testEncodeDecode(t *testing.T, salg SigningAlgorithm) {
 
 	// test invalid private keys (equal to the curve group order)
 	groupOrder := make(map[SigningAlgorithm][]byte)
-	groupOrder[ECDSAP256] = []byte{255, 255, 255, 255, 0, 0, 0, 0, 255, 255, 255, 
-		255, 255, 255, 255, 255, 188, 230, 250, 173, 167, 
+	groupOrder[ECDSAP256] = []byte{255, 255, 255, 255, 0, 0, 0, 0, 255, 255, 255,
+		255, 255, 255, 255, 255, 188, 230, 250, 173, 167,
 		23, 158, 132, 243, 185, 202, 194, 252, 99, 37, 81}
-		
-	groupOrder[ECDSASecp256k1] = []byte{255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 
-		255, 255, 255, 255, 255, 254, 186, 174, 220, 230, 
+
+	groupOrder[ECDSASecp256k1] = []byte{255, 255, 255, 255, 255, 255, 255, 255, 255, 255,
+		255, 255, 255, 255, 255, 254, 186, 174, 220, 230,
 		175, 72, 160, 59, 191, 210, 94, 140, 208, 54, 65, 65}
-	
-	groupOrder[BLSBLS12381] = []byte{0x73, 0xED, 0xA7, 0x53, 0x29, 0x9D, 0x7D, 0x48, 0x33, 0x39, 
-		0xD8, 0x08, 0x09, 0xA1, 0xD8, 0x05, 0x53, 0xBD, 0xA4, 0x02, 0xFF, 0xFE, 
+
+	groupOrder[BLSBLS12381] = []byte{0x73, 0xED, 0xA7, 0x53, 0x29, 0x9D, 0x7D, 0x48, 0x33, 0x39,
+		0xD8, 0x08, 0x09, 0xA1, 0xD8, 0x05, 0x53, 0xBD, 0xA4, 0x02, 0xFF, 0xFE,
 		0x5B, 0xFE, 0xFF, 0xFF, 0xFF, 0xFF, 0x00, 0x00, 0x00, 0x01}
 	_, err = DecodePrivateKey(salg, groupOrder[salg])
 	require.Error(t, err, "the key decoding should fail - private key value is too large")

integration/tests/access/access_api_test.go

@@ -57,7 +57,7 @@ func (suite *AccessSuite) SetupTest() {
 		conID := unittest.IdentifierFixture()
 		nodeConfig := testnet.NewNodeConfig(flow.RoleConsensus,
 			testnet.WithID(conID),
-			testnet.AsGhost(),
+			testnet.AsGhost())
 		nodeConfigs = append(nodeConfigs, nodeConfig)
 	}