Deploy StakingProxy, LockedTokens and StakingCollection #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danuio
requested review from
jordanschalm and
kc1116
and removed request for
ramtinms and
janezpodhostnik
Merged
kc1116
approved these changes
Jul 20, 2021
jordanschalm
approved these changes
Jul 20, 2021
Co-authored-by: Jordan Schalm <jordan@dapperlabs.com>
…m:onflow/flow-go into danu/5683/test-env-machine-account-script
Codecov Report
@@ Coverage Diff @@
## feature/epochs #997 +/- ##
==================================================
- Coverage 56.39% 54.11% -2.29%
==================================================
Files 451 309 -142
Lines 26801 21064 -5737
==================================================
- Hits 15115 11399 -3716
+ Misses 9618 8120 -1498
+ Partials 2068 1545 -523
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
kc1116
approved these changes
Jul 22, 2021
| @@ -1274,7 +1274,7 @@ func TestAccountBalanceFields(t *testing.T) { | |||
| assert.NoError(t, err) | |||
| assert.NoError(t, script.Err) | |||
|
|
|||
| assert.Equal(t, cadence.UFix64(9999_5030), script.Value) | |||
| assert.Equal(t, cadence.UFix64(9999_5020), script.Value) | |||
There was a problem hiding this comment.
Hey @ramtinms this value changed after we deployed some extra contracts during execution state bootstrapping in this PR - is that expected and is it OK to update this expected value?
There was a problem hiding this comment.
yeah should be fine, it makes sense if we have deployed more contracts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/dapperlabs/flow-go/issues/5682.
StakingProxycontractLockedTokenscontractStakingCollectioncontract