Dynamically select emulator ports from machine instead of static ports specified by user or defaults #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2d3668b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jribbink
changed the title
jribbink
changed the title
…le ports in order to abstract user away from concept of emulator ports prevent any sort of overlap with already running emulator.
jribbink
force-pushed
the
jribbink/auto-select-port
branch
from
a53752b
to
55233d4
Compare
jribbink
force-pushed
the
jribbink/auto-select-port
branch
from
febc21c
to
e990f08
Compare
gregsantos
requested changes
Jun 30, 2022
There was a problem hiding this comment.
Should prob clean up the README and docs/emulator.md reflect these changes and clarify how/if emulator should be started
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #113