Added debugger port & dropped support for Flow CLI versions <1.0.0 #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 648b5ff The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Dependency Testbed
Release VersionThe package containing these changes will be released with version 0.4.0 |
Coverage report
Show files with reduced coverage 🔻
Test suite run success111 tests passing in 15 suites. Report generated by 🧪jest coverage report action from 648b5ff |
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #219
Description
There's been a number of changes Flow CLI/emulator recently. Some of these have broken Flow JS Testing (changes to the logging format, addition of the debugger, etc.). This PR adds the debugger port and restricts Flow JS Testing to v1.0.0 of the CLI and above. (since if versions of Flow CLI prior to these changes were used with version of Flow JS Testing, logs wouldn't properly be captured and an unknown flag
--debugger-portwould be passed to CLI)I think technically these breaking changes were rolled out around v0.45.4 from what I can see, but v1.0.0 seems like a better number to cutoff at considering that there may be other major changes we are overlooking that were introduced with the advent of v1.0.0
For contributor use:
masterbranchFiles changedin the Github PR explorer