Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when cookies are disabled. #136

Merged
merged 1 commit into from
Mar 26, 2021
Merged

Conversation

10thfloor
Copy link
Contributor

@10thfloor 10thfloor commented Mar 25, 2021

Screen Shot 2021-03-24 at 5 06 45 PM

@vercel
Copy link

vercel bot commented Mar 25, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/onflow/flow-playground/Dmz7eRudToD4Ko6vNueFAmVix6Xj
✅ Preview: https://flow-playground-git-mackenzie-cookies-warning-onflow.vercel.app

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but maybe keep the whole style refactoring to separate PRs

Comment on lines +68 to +70
The Playground uses cookies to manage projects. You'll need to
enable cookies in your browser to use the Playground. We don't use
cookies to track you, or collect your personal information.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having each line in a separate paragraph makes this more readable.

Comment on lines +67 to +71
<p>
The Playground uses cookies to manage projects. You'll need to
enable cookies in your browser to use the Playground. We don't use
cookies to track you, or collect your personal information.
</p>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<p>
The Playground uses cookies to manage projects. You'll need to
enable cookies in your browser to use the Playground. We don't use
cookies to track you, or collect your personal information.
</p>
<p>The Playground uses cookies to manage projects.</p>
<p>
You'll need to enable cookies in your browser to use the Playground. We don't use
cookies to track you, or collect your personal information.
</p>

@10thfloor 10thfloor merged commit 9f89a16 into master Mar 26, 2021
@kerrywei kerrywei linked an issue Dec 16, 2021 that may be closed by this pull request
@bthaile bthaile deleted the mackenzie/cookies-warning branch May 16, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show popup with "No Cookies Enabled" info
2 participants