Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recreate tutorials in live playground, update links in Example.tsx #187

Merged

Conversation

hichana
Copy link
Contributor

@hichana hichana commented Nov 16, 2021

Closes: #186

Description

Issue #186 found that tutorial playgrounds contract deployment resulted in a blank screen and console error. After trying all of the tutorial playgrounds I found they all have the same issue. This PR has updated links in Examples.tsx with newly-created versions of each tutorial playground instance saved to the api via play.onflow.org. It resolves the issue of user's clicking on a tutorial and facing this issue when trying to deploy contracts or fork the project.

Note, the underlying issue still needs to be investigated, as previously saved playgrounds that users may have might have the same issue. I will open a new issue to document that.


For contributor use:

  • [x ] Targeted PR against correct branch (see CONTRIBUTING.md)
  • [x ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • [x ] Code follows the standards mentioned here.
  • [n/a ] Updated relevant documentation
  • [x ] Re-reviewed Files changed in the Github PR explorer
  • [x ] Added appropriate labels

@vercel
Copy link

vercel bot commented Nov 16, 2021

@hichana is attempting to deploy a commit to the Flow Team on Vercel.

A member of the Team first needs to authorize it.

src/components/Examples.tsx Outdated Show resolved Hide resolved
src/components/Examples.tsx Outdated Show resolved Hide resolved
@joshuahannan
Copy link
Member

Thanks for updating these! I've been going through an updating the tutorials recently and didn't know about these links so the first two were out of date anyway so I've added the correct links here. I've got my PR open for the fungible token tutorial if you'd like to give it a review! onflow/cadence#1238

@hichana
Copy link
Contributor Author

hichana commented Nov 17, 2021

Ok, links changed @joshuahannan !

Copy link
Contributor Author

@hichana hichana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, all changed.

@10thfloor 10thfloor merged commit 8b1e45d into onflow:master Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flow playground broken during deployment
3 participants