Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small issues #228

Merged
merged 4 commits into from
Feb 17, 2022
Merged

Fix small issues #228

merged 4 commits into from
Feb 17, 2022

Conversation

MaxStalker
Copy link
Contributor

@MaxStalker MaxStalker commented Feb 17, 2022

Changes

  • New language client was created after switch to another editor. Fixed by storing and reusing language clients
  • Fix language server error, when starting with empty project
  • Decode browser tab and description from project title (special characters were in Helmet title)

Tests

  • - Manually Tested. All working properly 👌

There are nor unit nor integration tests in Playground - those would require an issue of their own first 🤷

@vercel
Copy link

vercel bot commented Feb 17, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/onflow/flow-playground/6ydWSYRYAgKjZL6PAWpaD5fVmjUn
✅ Preview: https://flow-playground-git-max-fix-small-issues-onflow.vercel.app

@MaxStalker MaxStalker mentioned this pull request Feb 17, 2022
@10thfloor 10thfloor merged commit 2e3323a into master Feb 17, 2022
@bthaile bthaile deleted the max/fix-small-issues branch May 16, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants