Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amit/bug fixes #279

Merged
merged 3 commits into from Jul 27, 2022
Merged

Amit/bug fixes #279

merged 3 commits into from Jul 27, 2022

Conversation

aishairzay
Copy link
Contributor

@aishairzay aishairzay commented Jul 26, 2022

Description

This PR addresses the following bugs in playground:

  • Changing of code not reflecting when resending a transaction or script
  • Changing of transaction parameters not reflecting when resending a transaction or script

Some of these fixes are done by reverting previously made changes in commits from a few months ago which I noticed were causing these bugs to come up on the production site. Specifically those changes that were reverted were put in to add some memoization for performance reasons. I don't have much context on how important those changes were, so would greatly appreciate some extra context around that.

Manually tested across many example scripts + transactions.

Reproduction steps which you can run on play.onflow.org and on this local version to see the difference in functionality:

  1. Open Playground on fresh incognito browser.
  2. Head to default created transaction.
  3. Remove references to helloworld
  4. Modify parameter like so: transaction(a: Int) {
  5. Add log in prepare like so: log(a)
  6. Fill in int param, and click send.
  7. It often fails first time due to a different bug which I have not fixed (Error: GraphQL error: addresses must be 8 bytes). If so, just modify the code again (space and backspace)
  8. Add more params and logs, and verify that clicking send works as expected for each change

@vercel
Copy link

vercel bot commented Jul 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
flow-playground ✅ Ready (Inspect) Visit Preview Jul 26, 2022 at 8:17PM (UTC)

@MaxStalker
Copy link
Contributor

afaik, Playground is not supporting incognito mode 🤔

@aishairzay
Copy link
Contributor Author

afaik, Playground is not supporting incognito mode

That would explain why I couldn't test contracts in incognito 😅
The transactions + script testing does work reliably in incognito if not deploying/using contracts.

Same test scenario can be run without incognito though.

@gpavlov2016 gpavlov2016 merged commit f94463c into staging Jul 27, 2022
@bthaile bthaile deleted the amit/bug-fixes branch May 16, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants