Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide deploy/send/execute btn loading state while project is auto-saving #375

Merged
merged 1 commit into from Oct 6, 2022

Conversation

alse
Copy link
Contributor

@alse alse commented Oct 4, 2022

Auto-saving caused the action button to flash frequently as it was being disabled. This hides the visual disabled state while keeping the button disabled on auto-save.

Closes: #370


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

Auto-saving caused the action button to flash frequently as it was
being disabled. This hides the visual disabled state while keeping
the button disabled on auto-save.
@vercel
Copy link

vercel bot commented Oct 4, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
flow-playground ✅ Ready (Inspect) Visit Preview Oct 4, 2022 at 8:49PM (UTC)

@vercel vercel bot temporarily deployed to Preview October 4, 2022 20:49 Inactive
Copy link
Contributor

@MrDSGC MrDSGC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

? 'buttons.primary'
: 'buttons.disabled'
}
disabled={disabled}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be shorthand

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The disabled prop?

@alse alse merged commit b02d74d into staging Oct 6, 2022
@alse alse deleted the as/hidden-disabled-state branch October 6, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't show the loading deploy/send/execute loading states while project is auto-saving
2 participants