Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node operator guide to deal with a byzantine node #1260

Merged
merged 14 commits into from Feb 8, 2023

Conversation

vishalchangrani
Copy link
Contributor

Closes: #???

Description


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

vishalchangrani and others added 3 commits February 3, 2023 15:37
Co-authored-by: j pimmel <frankly.watson@gmail.com>
Co-authored-by: j pimmel <frankly.watson@gmail.com>
Co-authored-by: j pimmel <frankly.watson@gmail.com>
@bluesign
Copy link
Contributor

bluesign commented Feb 6, 2023

this seems very big power to give to node operator, without any consequences. What will happen node operator blocks a non-byzantine node as a byzantine one ?

Is this only targeted for ANs? If so can we say we enable permissionless AN little premature?

@vishalchangrani
Copy link
Contributor Author

this seems very big power to give to node operator, without any consequences. What will happen node operator blocks a non-byzantine node as a byzantine one ?

Is this only targeted for ANs? If so can we say we enable permissionless AN little premature?

If node operators block a byzantine node then their node will not receive all the data it needs to function. e.g. if a verification node blocks an execution node then it may not receive the execution results.

@vishalchangrani vishalchangrani marked this pull request as ready for review February 6, 2023 17:30
@bluesign
Copy link
Contributor

bluesign commented Feb 6, 2023

If node operators block a byzantine node then their node will not receive all the data it needs to function. e.g. if a verification node blocks an execution node then it may not receive the execution results.

so this is only targeted for misbehaving AN ( byzantine is not apply here I guess ) ?

@peterargue
Copy link
Contributor

so this is only targeted for misbehaving AN ( byzantine is not apply here I guess ) ?

This is intended for node operators to deal with attacks from other nodes on the network. Whether the behavior is intentional or a bug is hard to determine, so the triaging steps include coordinating with other operators to add context. I just added some more details to cover that part of the process.

@bluesign
Copy link
Contributor

bluesign commented Feb 6, 2023

This is intended for node operators to deal with attacks from other nodes on the network. Whether the behavior is intentional or a bug is hard to determine, so the triaging steps include coordinating with other operators to add context. I just added some more details to cover that part of the process.

thanks for the clarification

@vishalchangrani vishalchangrani merged commit 36039fb into master Feb 8, 2023
@vishalchangrani vishalchangrani deleted the vishal/pan_part3 branch February 8, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants