Update transaction-lifecycle.md #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
initial draft for tx lifecycle Input needed from: * protocol team on`Validation` `clustering` `verification` and `sealing` sections cc @franklywatson * FVM team on `Execution` and `computation` cc @fotescodev @ramtinms
updates to urls
missed fixing one nodes url
|
@janezpodhostnik are you able to jump in from an FVM perspective on the computation and execution sections above? |
franklywatson
approved these changes
Feb 13, 2023
| [GetTransactionResult](/nodes/access-api#gettransaction): an execution node is requested for events for the transaction and the transaction status is derived as follows: | ||
| * If the collection containing the transaction and the block containing that collection is found locally, but the transaction has expired then its status is returned as `expired`. | ||
| * If either the collection or the block is not found locally, but the transaction has not expired, then its status is returned as `pending` | ||
| If the transaction has neither expired nor is it pending, but the execution node has not yet executed the transaction, then the status of the transaction is returned as `finalized`. |
There was a problem hiding this comment.
Suggested change
| If the transaction has neither expired nor is it pending, but the execution node has not yet executed the transaction, then the status of the transaction is returned as `finalized`. | |
| * If the transaction has neither expired nor is it pending, but the execution node has not yet executed the transaction, then the status of the transaction is returned as `finalized`. |
| * If the collection containing the transaction and the block containing that collection is found locally, but the transaction has expired then its status is returned as `expired`. | ||
| * If either the collection or the block is not found locally, but the transaction has not expired, then its status is returned as `pending` | ||
| If the transaction has neither expired nor is it pending, but the execution node has not yet executed the transaction, then the status of the transaction is returned as `finalized`. | ||
| * If the execution node has executed the transaction, then if the height of the block containing the transaction is greater than the highest sealed block, then the status of the transaction is returned as `executed` else it is returned as `sealed`. |
There was a problem hiding this comment.
Suggested change
| * If the execution node has executed the transaction, then if the height of the block containing the transaction is greater than the highest sealed block, then the status of the transaction is returned as `executed` else it is returned as `sealed`. | |
| * If the execution node has executed the transaction, and if the height of the block containing the transaction is greater than the highest sealed block, then the status of the transaction is returned as `executed` else it is returned as `sealed`. |
|
@laynelafrance I can take a look later this week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initial draft for tx lifecycle
Input needed from:
Validationclusteringverificationandsealingsections cc @franklywatsonExecutionandcomputationcc @fotescodev @ramtinmsCloses: slack discussion
Description
For contributor use:
masterbranchFiles changedin the Github PR explorer