[Access] Add latest finalized block ID and height #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterargue
reviewed
Apr 12, 2023
There was a problem hiding this comment.
Thanks for the PR @Guitarheroua!
This looks pretty good. 2 general comments:
- I think we should reframe the entity as
Metadataso it can be extended in the future. - Please also include the metadata in the following response objects:
SendTransactionResponseExecuteScriptResponseTransactionResultResponseTransactionResultsResponse(we'll want to omit the metadata within eachTransactionResultResponsewhen sending this)
PingResponse and GetNetworkParametersResponse were also skipped, but I agree that it's not needed for those.
| option go_package = "github.com/onflow/flow/protobuf/go/flow/entities"; | ||
| option java_package = "org.onflow.protobuf.entities"; | ||
|
|
||
| message LastFinalizedBlock { |
There was a problem hiding this comment.
Can we call this Metadata? That way it can be extended to include additional information in the future. Please also rename the file and arguments. maybe something like latest_finalized_block_id and latest_finalized_height
* Renamed `LastFinalizedBlock` to `Metadata`. Renamed fields. * Added `metadata` to more queries responces.
peterargue
approved these changes
Apr 14, 2023
|
|
||
| message Metadata { | ||
| bytes latest_finalized_block_id = 1; | ||
| uint64 latest_finalized_height = 2; |
There was a problem hiding this comment.
I should have asked in my previous request. Can you also add bytes node_id
There was a problem hiding this comment.
Sorry, I missed it in a ticket. Added with a7105d4
koko1123
approved these changes
Apr 17, 2023
bors bot
added a commit
to onflow/flow-go
that referenced
this pull request
Apr 27, 2023
4191: [Access] Add latest block Height and ID to api responses r=peterargue a=Guitarheroua #2906 ### Context This pull request extends the necessary responses for the Access Node with additional fields containing information about the finalized block ID and height. To achieve this, the `synchronization.FinalizedHeaderCache` was propagated to the Access Node handler, and finalized block ID and height were added to query responses As part of this PR: * The protobuf structures were extended([PR 1325](onflow/flow#1325)) * The tests in [access_test.go](https://github.com/onflow/flow-go/blob/master/engine/access/access_test.go) were updated ### Note: * These changes include only GRPC modifications and not REST. REST changes will be made in a separate pull request after getting a reply on [the issue comment](#2906 (comment)). Co-authored-by: Andriy Slisarchuk <andriyslisarchuk@gmail.com> Co-authored-by: Andrii Slisarchuk <Guitarheroua@users.noreply.github.com> Co-authored-by: Andrii Slisarchuk <andriyslisarchuk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onflow/flow-go#2906
Description
Extended necessary responses for the Access Node with additional fields containing information about the finalized block ID and height.