Store sale offer events for marketplace sale-item collection. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10thfloor
commented
Feb 18, 2021
10thfloor
commented
Feb 18, 2021
|
Upon further consideration, we should not be querying over all events, because performance will degrade, the more users are sending events to the system. Going to try to only keep records of sales in the DB by adding/removing based on events received. |
Merged
10thfloor
commented
Feb 24, 2021
10thfloor
commented
Feb 24, 2021
psiemens
reviewed
Mar 23, 2021
This was referenced Mar 24, 2021
psiemens
reviewed
Mar 25, 2021
There was a problem hiding this comment.
Something strange is happening when I test out the FE app.
After listing an item for sale:
- The "List" button changed to "Unlist" but the spinner never stops
- My laptop fans starting ramping up. I tried to switch to the "Marketplace Items" tab -- it was very slow to change tabs, and after a few seconds Chrome disabled the tab
- I then tried reloading the page in Firefox too, but it also froze and the tab was killed by FF
Any chance there's a runaway loop in the frontend code?
10thfloor
force-pushed
the
mackenzie/collect-sale-offers
branch
from
148341c
to
c5aa0ff
Compare
This was referenced Mar 26, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no way to see all items available for sale in the marketplace.
This PR is an attempt to create such a list by capturing sale-offer events using the events worker.
This PR also removes the
kitty_itemstable.