Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying relative path for custom flow.json locations #315

Closed
jribbink opened this issue May 6, 2023 · 0 comments · Fixed by #348
Closed

Allow specifying relative path for custom flow.json locations #315

jribbink opened this issue May 6, 2023 · 0 comments · Fixed by #348
Assignees
Labels
feature A new user feature or a new package API feedback

Comments

@jribbink
Copy link
Contributor

jribbink commented May 6, 2023

Instructions

Issue To Be Solved

The VSCode Extension does not find the file if I specify a relative path for a custom flow.json location. This feels a bit misleading IMO because the flow.json will always be a descendent of the workspace root, so resolving relative paths from here seems somewhat intuitive. Not to mention it makes the repository impossible to clone & dependent on the user's particular directory structure.

We should be resolving the path using path.resolve to prevent this. This way both users trying to specify absolute and relative paths can be accommodated.

(Optional): Suggest A Solution

Use path.resolve 😛

(Optional): Context

Took me a while to debug why I couldn't specify my custom flow.json location

@jribbink jribbink added feedback feature A new user feature or a new package API labels May 6, 2023
@jribbink jribbink self-assigned this May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new user feature or a new package API feedback
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants