Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contracts under dependencies fields cannot be properly loaded when config them in deployment fields. #542

Closed
btspoony opened this issue Feb 19, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@btspoony
Copy link

Instructions

If the contract only exists in the dependencies field and not in the contracts field of flow.json, when it is configured in the deployment field, the vscode plugin will report an error and language server will be broken.

Problem

The language server will be broken with a error thrown.

Steps to Reproduce

image

Acceptance Criteria

contracts in the dependencies field can be add to deployment field and no error occurs.

Context

VSCode plugin: v2.2.1
flow-cli: v1.13.2

@btspoony btspoony added the bug Something isn't working label Feb 19, 2024
@btspoony
Copy link
Author

btspoony commented Apr 2, 2024

There is another issue, if dependencies are not configured in the contracts field.
An importing error will be reported.
image
After adding all dependencies to the contracts field, then it works.
image
image

@jribbink
Copy link
Contributor

jribbink commented Apr 30, 2024

@btspoony

Is this still an issue in the latest version of the Flow CLI (I can't reproduce it on v1.18.0)? We had an issue where the Cadence Language server was using an outdated version of flowkit (which meant in turn that dependency manager didn't work in the LS).

But I believe this issue should be fixed now.

@jribbink jribbink self-assigned this Apr 30, 2024
@btspoony
Copy link
Author

Yeah, it is fixed now.
I removed all duplicated contracts in contracts fields. and it works.

@btspoony
Copy link
Author

@jribbink
Copy link
Contributor

Amazing, glad to hear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants