Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI version switching #560

Merged
merged 17 commits into from
Mar 22, 2024
Merged

Add CLI version switching #560

merged 17 commits into from
Mar 22, 2024

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Mar 18, 2024

Closes #538

Description

Adds ability to select versions of the CLI with native support for flow-c1


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@jribbink jribbink added the improvement Technical work without new features label Mar 19, 2024
@jribbink jribbink marked this pull request as ready for review March 19, 2024 16:28
@jribbink jribbink changed the title Jribbink/c1 mode Add CLI version switching Mar 20, 2024
@jribbink
Copy link
Contributor Author

tests pass locally - there are seemingly issues with @vscode/test-electron that break these, will be addressed subsequently (probably need to update)

Copy link

@bthaile bthaile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bthaile
Copy link

bthaile commented Mar 21, 2024

How does the correct language server get chosen based on the version of flow-cli used?

@jribbink
Copy link
Contributor Author

How does the correct language server get chosen based on the version of flow-cli used?

The LanguageServerAPI watches for the binary to change from the CliProvider and will restart accordingly. I realized it maybe wasn't super clear, so I've moved some stuff around and added some more comments to make it more obvious that this is how it works.

@jribbink jribbink merged commit 1ac5a1f into master Mar 22, 2024
3 of 6 checks passed
@jribbink jribbink deleted the jribbink/c1-mode branch March 22, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Technical work without new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Cadence 1.0 Mode
2 participants