Fix the 'unfinished animation' issue. Add some file to gitignore too #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gonna fix an issue which can be inferred from the following screenshot:
It happens when I use a button to navigate the ViewPager (dynamically call
ViewPager#setCurrentItem(int, boolean)with thesmoothlyScrollset to true). If I press the button fast enough, your Animations would not finished the old one before starting the new ones (the duration of 200 ms is longer than my pressing duration). So I end up ending the Animations before starting the new ones.Furthermore I add some local file to gitignore to prevent screwing up other contributors on their local environment. You can revert them if you want. Please check out.