Add tag validator with apostrophes #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
French tags with apostrophes won't be accepted by current validators. A validator that accepts these french tags is needed.
Create separate validators file, as future features will include more validators.
Add specific tag validator messages for commas and consecutive spaces. Also, strip the value.
Move general imports outside of specific function.
Missing import of Invalid.
No need to escape the first apostrophe in the regular expression. As well, that apostrophe throws an error when printed in the console, so it should be removed from the invalid message.
Some keywords submitted have had separators that throw an error in the tag validator. These separators aren't desirable. Add a component to the validator that replaces undesirable separators with a space.
…add_tag_validator_with_apostrophes
Recent merge created two get_validators functions in plugin.py. Merge these two.
These imports are only needed in validators.py
…a/ckanext-ontario_theme into add_tag_validator_with_apostrophes
Invalid errors borrowed from Government of Canada ckan passes value as a tuple, but it looks to be in error.
Validator message encoding was partially ascii. Fixed to unicode to be able to include apostrophe.
boykoc
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of 8 commits to create an ontario_theme-specific tag validator.
The changes that deviate from ckan core are: