Merge pull request #47 from tompoc/do_not_silent_errors

Do not silent errors
ongr-io · Mar 18, 2016 · aeaba59 · aeaba59
2 parents 7a5c71c + 65439be
commit aeaba59
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/Driver/EcbDriver.php b/Driver/EcbDriver.php
@@ -22,7 +22,7 @@ class EcbDriver implements CurrencyDriverInterface
     public function getRates()
     {
         $rates = [];
-        $xml = @simplexml_load_file('http://www.ecb.europa.eu/stats/eurofxref/eurofxref-daily.xml');
+        $xml = simplexml_load_file('http://www.ecb.europa.eu/stats/eurofxref/eurofxref-daily.xml');
         $data = $xml->xpath('//gesmes:Envelope/*[3]/*');
         foreach ($data[0]->children() as $child) {
             $code = (string)$child->attributes()->currency;

diff --git a/Tests/app/config/config_test.yml b/Tests/app/config/config_test.yml
@@ -75,5 +75,3 @@ services:
         class: ONGR\CurrencyExchangeBundle\Tests\FooSettingsProvider
         tags:
             - { name: ongr_currency_exchange.settings_provider, method: getFooSets } # method attribute is optional
-
-