Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Guzzle package optional #40

Merged
merged 1 commit into from
Jan 15, 2016
Merged

Make Guzzle package optional #40

merged 1 commit into from
Jan 15, 2016

Conversation

trandangtri
Copy link
Contributor

Closes #34.

@saimaz saimaz added the qa label Jan 6, 2016
@trandangtri
Copy link
Contributor Author

Please merge #41 first.

@saimaz
Copy link
Member

saimaz commented Jan 7, 2016

I see there is still guzzle ~5.0 in our requirements, the new major version is 6. Excpet the difference that 6'th version supports PSR-7 are there any other differences or BC brakes? I think we should suggest to use the latest major version.

@trandangtri
Copy link
Contributor Author

Some updates from v5 to v6, we could take a look at here
https://github.com/guzzle/guzzle/blob/master/UPGRADING.md

As I knew, we are using Guzzle in CurrencyExchangeBundle only. And all tests passed after I'd updated the Guzzle lib. So what do you think if I upgrade it to the latest version? Furthermore, this is just an optional library.

@saimaz
Copy link
Member

saimaz commented Jan 8, 2016

Yes you should update to Guzzle 6.0

@trandangtri
Copy link
Contributor Author

I did, thanks @saimaz.

@trandangtri
Copy link
Contributor Author

How's about this, guys?

@saimaz
Copy link
Member

saimaz commented Jan 15, 2016

Can you rebase it to one commit?

@trandangtri
Copy link
Contributor Author

Yes, I did

saimaz added a commit that referenced this pull request Jan 15, 2016
@saimaz
Merge pull request #40 from trandangtri/guzzle-optional
7bbb38c 
Make Guzzle package optional
@saimaz saimaz merged commit 7bbb38c into ongr-io:master Jan 15, 2016
@saimaz saimaz removed the qa label Jan 15, 2016
@trandangtri trandangtri deleted the guzzle-optional branch January 18, 2016 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@trandangtri @saimaz