Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Collection class as a holder for multiple objects #527

Merged
merged 3 commits into from
Jan 5, 2016
Merged

Introduce Collection class as a holder for multiple objects #527

merged 3 commits into from
Jan 5, 2016

Conversation

mvar
Copy link
Member

@mvar mvar commented Jan 4, 2016

This PR adds requirement to use Collection for "multiple objects" properties. ObjectIterator now extends Collection.

Not sure about the naming and namespaces.

Closes #525

This adds ability to append new object
@mvar mvar added the qa label Jan 4, 2016
@saimaz
Copy link
Member

saimaz commented Jan 4, 2016

Collection as a name is too abstract, IMO at least it has to be named ObjectCollection or something similar.

@saimaz
Copy link
Member

saimaz commented Jan 4, 2016

Also the docs about how to define object/nested is missing. I mean we have to write in the docs that there is necessary to add a collection in a document constructor.

@mvar
Copy link
Member Author

mvar commented Jan 5, 2016

Name left as it is. It may sound abstract, but it actually is quite abstract. Collection is basically array wrapper. We use it for single case, but it could be easily used for many other purposes.

Also updated docs.

saimaz added a commit that referenced this pull request Jan 5, 2016
Introduce Collection class as a holder for multiple objects
@saimaz saimaz merged commit 4628894 into ongr-io:master Jan 5, 2016
@saimaz saimaz removed the qa label Jan 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants