Refactor aggregations result handling #555
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes:
Quicker properties access:
Now you can directly access aggregation properties using array access syntax.
Before:
After:
Logically separated buckets
From now on all aggregations are returned as instance of
ValueAggregation
(previously bucketed aggregations were returned as iterator of buckets). This means all aggregation properties can be reached the same way as with metric aggregations. You still can iterate over buckets by using aggregation itself as iterator. You can get array of buckets by callinggetBuckets()
.Before:
After:
Closes #554