Instance Cache added to DocumentParser::parse() #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
carlcasbolt
commented
May 17, 2017
carlcasbolt
commented
- I've discovered that this method was being called a lot of times when indexing large volumes of documents with my bulk indexer code.
- Constantly parsing a Reflection class was becoming too costly so I've added an instance cache to store the document information.
|
Nice catch @carlcasbolt. Thank you for the PR. |
|
I changed the base to 5.0, could you please rebase your PR branch accordingly? |
|
rebasing now |
carlcasbolt
force-pushed
the
DocumentParser-document-cache
branch
from
06ba756
to
0f3dbad
Compare
- I've discovered that this method was being called a lot of times when indexing large volumes of documents with my bulk indexer code. - Constantly parsing a Reflection class was becoming too costly so I've added an instance cache to store the document information.
carlcasbolt
force-pushed
the
DocumentParser-document-cache
branch
from
0f3dbad
to
431c986
Compare
|
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.