Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mapping now based on property instead of class #817

Merged
merged 1 commit into from Mar 22, 2018
Merged

Mapping now based on property instead of class #817

merged 1 commit into from Mar 22, 2018

Conversation

kleinkoerkamp
Copy link
Contributor

closes #803.

Because of inheritance the mapping was always based on the highest level class, now looking to the class where the property is defined in.

@alexander-schranz
Copy link
Contributor

if this fixes #803 this would make #804 unnecessary for me.

@kleinkoerkamp kleinkoerkamp reopened this Oct 17, 2017
@alexander-schranz alexander-schranz mentioned this pull request Jan 9, 2018
Closed
@alexander-schranz
Copy link
Contributor

Any updates to this @saimaz? /cc @kleinkoerkamp

@alexander-schranz alexander-schranz mentioned this pull request Mar 8, 2018
Closed
@saimaz saimaz merged commit 665c286 into ongr-io:5.0 Mar 22, 2018
@kleinkoerkamp kleinkoerkamp deleted the mapping_embed_extended branch March 23, 2018 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kleinkoerkamp @alexander-schranz @saimaz