Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] ECR image hook #490

Closed
5 of 7 tasks
ITProKyle opened this issue Dec 2, 2020 · 2 comments · Fixed by #493
Closed
5 of 7 tasks

[REQUEST] ECR image hook #490

ITProKyle opened this issue Dec 2, 2020 · 2 comments · Fixed by #493
Assignees
Labels
feature Request or pull request for a new feature priority:medium Medium priority issue or pull request

Comments

@ITProKyle
Copy link
Contributor

ITProKyle commented Dec 2, 2020

With the release of public ECR (in response to Docker Hub limits) and the ability to use ECR images as Lambda function deployment package ECR is now a very appealing option. There is a void in capabilities to build, test, and push images.

Acceptance Criteria

  • build docker image
  • optionally test the image leaving this out for now, until there is a need for it
  • push the image that was built
  • push image that has already been built
  • delete image locally and/or from ECR
  • provide access to sane docker options in the build/push process
  • return information relevant to use as Lambda function deployment package and with other services
@ITProKyle ITProKyle added feature Request or pull request for a new feature priority:medium Medium priority issue or pull request labels Dec 2, 2020
@ITProKyle ITProKyle added this to To do in Runway Development Work via automation Dec 2, 2020
@ITProKyle ITProKyle added the status:in_progress Task is actively being worked on label Dec 7, 2020
@ITProKyle ITProKyle moved this from To do to In progress in Runway Development Work Dec 7, 2020
@ITProKyle ITProKyle removed the status:in_progress Task is actively being worked on label Dec 7, 2020
@ITProKyle
Copy link
Contributor Author

After starting work on the hook, I noticed most of the logic I was writing was around docker and not ECR. So, this is now going to be implemented as a docker hook with features to simplify use with ECR.

@ITProKyle
Copy link
Contributor Author

Looking into returning relevant info to use as a Lambda Function deployment package I noticed that CloudFormation documentation does not reflect supporting this yet while the release blog post stated that CloudFormation does support it.

Looking through the API docs, I was able to piece together a working CloudFormation template for testing. I also started a PR to add support to Troposphere (cloudtools/troposphere#1846).

Runway Development Work automation moved this from In progress to Done Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Request or pull request for a new feature priority:medium Medium priority issue or pull request
Projects
Development

Successfully merging a pull request may close this issue.

2 participants