New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add docker cfngin hook #493
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a hook to
docker image build
anddocker image push
with handling to simplify usage with AWS Elastic Container Registry.Why This Is Needed
resolves #490
What Changed
Added
runway.core.providers.docker
to extend the functionality ofdocker-py
runway.lookups.handlers.ecr
lookup to get information from either the runway or CFNgin configlogin-password
which returns the same value as the awscli commandaws ecr get-login-password
runway.cfngin.hooks.docker
to interact with docker by mimicking the functionality of the docker CLI. The following actions are currently supporteddocker.login
docker.image.build
docker.image.push
runway.cfngin.hooks.ecr.purge_repository
to remove all images in an ECR repository so it can be deleted by CloudFormation