Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docker cfngin hook #493

Merged
merged 15 commits into from Jan 14, 2021
Merged

add docker cfngin hook #493

merged 15 commits into from Jan 14, 2021

Conversation

ITProKyle
Copy link
Contributor

@ITProKyle ITProKyle commented Dec 9, 2020

Summary

Adds a hook to docker image build and docker image push with handling to simplify usage with AWS Elastic Container Registry.

Why This Is Needed

resolves #490

What Changed

Added

  • add runway.core.providers.docker to extend the functionality of docker-py
  • add runway.lookups.handlers.ecr lookup to get information from either the runway or CFNgin config
    • currently only supports a query of login-password which returns the same value as the awscli command aws ecr get-login-password
  • add runway.cfngin.hooks.docker to interact with docker by mimicking the functionality of the docker CLI. The following actions are currently supported
    • docker.login
      • options to simplify ECR authentication
    • docker.image.build
      • options to simplify building an image of ECR
    • docker.image.push
      • options to simplify pushing an image to ECR
  • add runway.cfngin.hooks.ecr.purge_repository to remove all images in an ECR repository so it can be deleted by CloudFormation

@ITProKyle ITProKyle added the feature Request or pull request for a new feature label Dec 9, 2020
@ITProKyle ITProKyle self-assigned this Dec 9, 2020
@ITProKyle ITProKyle added this to In progress in Runway Development Work via automation Dec 9, 2020
@ITProKyle ITProKyle marked this pull request as ready for review December 15, 2020 17:12
@troyready troyready merged commit 91165da into onicagroup:master Jan 14, 2021
Runway Development Work automation moved this from In progress to Done Jan 14, 2021
@ITProKyle ITProKyle deleted the feature/docker-hook branch February 3, 2021 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Request or pull request for a new feature
Projects
Development

Successfully merging this pull request may close these issues.

[REQUEST] ECR image hook
2 participants