Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change aws.s3.Bucket.exists, add aws.s3.Bucket.__bool__ #1133

Merged
merged 1 commit into from Jan 7, 2022
Merged

change aws.s3.Bucket.exists, add aws.s3.Bucket.__bool__ #1133

merged 1 commit into from Jan 7, 2022

Conversation

ITProKyle
Copy link
Contributor

Why This Is Needed

resolves #919

What Changed

Added

  • added runway.core.providers.aws.s3._bucket.Bucket.__bool__ which returns the value of .exists

Changed

  • runway.core.providers.aws.s3._bucket.Bucket.exists now factors in both .not_found and .forbidden for this value

@ITProKyle ITProKyle added the changelog:minor Minor change resulting in a minor release label Jan 7, 2022
@ITProKyle ITProKyle self-assigned this Jan 7, 2022
@ITProKyle ITProKyle added this to In progress in Runway Development Work via automation Jan 7, 2022
@github-actions github-actions bot added feature Request or pull request for a new feature python Update to Python code labels Jan 7, 2022
@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #1133 (f17c568) into master (35e3fe7) will decrease coverage by 0.00%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1133      +/-   ##
==========================================
- Coverage   89.48%   89.47%   -0.01%     
==========================================
  Files         247      247              
  Lines       15295    15297       +2     
==========================================
+ Hits        13686    13687       +1     
- Misses       1609     1610       +1
Impacted Files Coverage Δ
runway/core/providers/aws/s3/_bucket.py 98.59% <83.33%> (-1.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35e3fe7...f17c568. Read the comment docs.

@ITProKyle ITProKyle merged commit d315e65 into master Jan 7, 2022
Runway Development Work automation moved this from In progress to Done Jan 7, 2022
@ITProKyle ITProKyle deleted the feature/s3-bucket-bool branch January 7, 2022 19:49
@ITProKyle ITProKyle mentioned this pull request Jan 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ITProKyle ITProKyle

Labels
changelog:minor Minor change resulting in a minor release feature Request or pull request for a new feature python Update to Python code
Projects
Runway Development Work
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TODO] add _bool_ to runway.core.providers.aws.s3._bucket.Bucket
1 participant
@ITProKyle