Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid npm directory creation errors #168

Merged
merged 1 commit into from Feb 20, 2020
Merged

avoid npm directory creation errors #168

merged 1 commit into from Feb 20, 2020

Conversation

troyready
Copy link
Contributor

Certain versions of nodejs can have issues with the directory creation in the current symlink setup process. This small change should make it slightly more forgiving.

image

@ITProKyle ITProKyle added the bug Something isn't working label Feb 20, 2020
ITProKyle
ITProKyle approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@ITProKyle ITProKyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this works for you, its fine with me. is there any handling needed when EEXIST is raised or can it be assumed that the intended result was still achieved?

@troyready
Copy link
Contributor Author

... or can it be assumed that the intended result was still achieved?
Yeah, that's what I was thinking

@troyready troyready merged commit 5f69d38 into master Feb 20, 2020
@troyready troyready deleted the bugfix/npm_issues branch February 20, 2020 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ITProKyle ITProKyle ITProKyle approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@troyready @ITProKyle