Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix RunwayModule not subscriptable & awacs/troposphere unload causing isinstance inconsistencies #361

Merged
merged 4 commits into from
Jun 9, 2020

Conversation

ITProKyle
Copy link
Collaborator

Why This Is Needed

resolves #360 and fixes an unreported bug introduced by #354

What Changed

Changed

  • subclasses of RunwayModule are now subscriptable
  • SafeHaven is now able to exclude modules from being unloaded

Fixed

  • fixed an issue causing module commands to raise "TypeError: object is not subscriptable"
  • fixed an issue where troposphere was unable to properly assess types for some objects

@ITProKyle ITProKyle added bug Something isn't working priority:critical Critical priority issue or pull request labels Jun 9, 2020
@ITProKyle ITProKyle self-assigned this Jun 9, 2020
@ITProKyle ITProKyle marked this pull request as ready for review June 9, 2020 18:32
@ITProKyle ITProKyle requested a review from troyready June 9, 2020 18:32
@paul-duffy
Copy link
Contributor

There is a new error when running the deploy:

INFO:runway:---- Processing module 'sample-app' for 'dev' in us-east-1 --------------
INFO:runway:Module options: {'environments': {'dev': {'namespace': 'sample-app-dev', 'staticsite_cf_disable': True}, 'prod': {'namespace': 'sample-app-prod'}}, 'options': {'build_output': 'dist/sample-app', 'build_steps': ['npm install', 'npx ng build']}, 'parameters': {'namespace': 'sample-app-dev', 'staticsite_cf_disable': True}, 'name': 'sample-app', 'type': 'static', 'tags': {}, 'child_modules': [], 'class_path': None, 'env_vars': {}, 'path': 'sample-app', 'environment': True}
Traceback (most recent call last):
  File "/Users/pduffy/.local/share/virtualenvs/bugs-awxQH1y6/bin/runway", line 8, in <module>
    sys.exit(main())
  File "/Users/pduffy/.local/share/virtualenvs/bugs-awxQH1y6/lib/python3.7/site-packages/runway/cli.py", line 91, in main
    command_class(cli_arguments).execute()
  File "/Users/pduffy/.local/share/virtualenvs/bugs-awxQH1y6/lib/python3.7/site-packages/runway/commands/modules/deploy.py", line 55, in execute
    self.run(deployments=None, command='deploy')
  File "/Users/pduffy/.local/share/virtualenvs/bugs-awxQH1y6/lib/python3.7/site-packages/runway/commands/modules_command.py", line 386, in run
    self._process_deployments(deployments_to_run, context)
  File "/Users/pduffy/.local/share/virtualenvs/bugs-awxQH1y6/lib/python3.7/site-packages/runway/commands/modules_command.py", line 468, in _process_deployments
    self._execute_deployment(deployment, context, region)
  File "/Users/pduffy/.local/share/virtualenvs/bugs-awxQH1y6/lib/python3.7/site-packages/runway/commands/modules_command.py", line 490, in _execute_deployment
    self._process_modules(deployment, context)
  File "/Users/pduffy/.local/share/virtualenvs/bugs-awxQH1y6/lib/python3.7/site-packages/runway/commands/modules_command.py", line 527, in _process_modules
    self._deploy_module(module, deployment, context)
  File "/Users/pduffy/.local/share/virtualenvs/bugs-awxQH1y6/lib/python3.7/site-packages/runway/commands/modules_command.py", line 613, in _deploy_module
    module_instance[context.command]()
TypeError: 'StaticSite' object is not subscriptable

@ITProKyle
Copy link
Collaborator Author

That is a bug currently on master and was resolved in this commit

@troyready troyready merged commit 7760402 into rackspace:master Jun 9, 2020
@ITProKyle ITProKyle deleted the bugfix/isinstance branch June 9, 2020 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:critical Critical priority issue or pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Static module deploy fails
3 participants