Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add cfn lookup #387

Merged
merged 14 commits into from Jul 30, 2020
Merged

add cfn lookup #387

merged 14 commits into from Jul 30, 2020

Conversation

ITProKyle
Copy link
Contributor

Summary

A lookup that can be used to get the value of a CloudFormation Stack Output. This lookup can be used in both the Runway and CFNgin config files.

resolves #319

What Changed

Added

  • added the cfn Lookup, usable in Runway and CFNgin config files

Changed

  • terraform_backend_cfn_outputs option is now deprecated
  • xref Lookup is now deprecated
  • update some docs to comply with the rst format outlined in the developer guide

Fixed

  • fixed some Example rubrics that were missing their directive

@ITProKyle ITProKyle added the feature Request or pull request for a new feature label Jul 21, 2020
@ITProKyle ITProKyle self-assigned this Jul 21, 2020
@ITProKyle ITProKyle marked this pull request as ready for review July 21, 2020 23:06
@ITProKyle ITProKyle requested a review from troyready July 29, 2020 01:25
troyready
troyready approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@troyready troyready left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@troyready troyready merged commit ed7dbc0 into onicagroup:master Jul 30, 2020
@ITProKyle ITProKyle deleted the feature/cfn-lookup branch July 30, 2020 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@troyready troyready troyready approved these changes

Assignees

@ITProKyle ITProKyle

Labels
feature Request or pull request for a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REQUEST] add a cfn lookup
2 participants
@ITProKyle @troyready