Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strict type checking #539

Merged
merged 18 commits into from Feb 19, 2021
Merged

strict type checking #539

merged 18 commits into from Feb 19, 2021

Conversation

ITProKyle
Copy link
Contributor

Why This Is Needed

resolves #328

What Changed

Added

  • added more autogenerated stubs

Changed

  • updated various type annotations
  • update pyright

@ITProKyle ITProKyle self-assigned this Feb 18, 2021
@ITProKyle ITProKyle added the feature Request or pull request for a new feature label Feb 18, 2021
@ITProKyle ITProKyle added this to In progress in Runway Development Work via automation Feb 18, 2021
@ITProKyle ITProKyle linked an issue Feb 18, 2021 that may be closed by this pull request
[TODO] implement type hints with pyright for type checking #328
Closed
@ITProKyle ITProKyle changed the title string type checking strict type checking Feb 18, 2021
@ITProKyle ITProKyle marked this pull request as ready for review February 19, 2021 13:17
@ITProKyle ITProKyle merged commit fadf5ed into onicagroup:v2 Feb 19, 2021
Runway Development Work automation moved this from In progress to Done Feb 19, 2021
@ITProKyle ITProKyle deleted the feature/strict-typing branch February 19, 2021 13:35
ITProKyle added a commit that referenced this pull request Feb 25, 2021
@ITProKyle
strict type checking (#539)
fc75595
ITProKyle added a commit that referenced this pull request Mar 22, 2021
@ITProKyle
strict type checking (#539)
9b23e27
@ITProKyle ITProKyle added the changelog:minor Minor change resulting in a minor release label Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ITProKyle ITProKyle

Labels
changelog:minor Minor change resulting in a minor release feature Request or pull request for a new feature
Projects
Runway Development Work
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TODO] implement type hints with pyright for type checking
1 participant
@ITProKyle