Applied fixes from StyleCI

onigoetz · Sep 27, 2015 · 9c411e1 · 9c411e1
1 parent 65494ae
commit 9c411e1
Show file tree

Hide file tree

Showing 6 changed files with 28 additions and 31 deletions.
diff --git a/src/Application.php b/src/Application.php
@@ -21,6 +21,7 @@ protected function getDefaultCommands()
         $commands = parent::getDefaultCommands();
         $commands[] = new UpdateCommand();
         $commands[] = new ListCommand();
+
         return $commands;
     }
 }
diff --git a/src/Commands/AbstractCommand.php b/src/Commands/AbstractCommand.php
@@ -1,7 +1,6 @@
 <?php
 namespace Onigoetz\Dyn53\Commands;
 
-use Aws\Common\Exception\LogicException;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputOption;
@@ -33,10 +32,10 @@ protected function configure()
 
     protected function readConfig(InputInterface $input)
     {
-        $config = array();
+        $config = [];
         $file = $input->getOption('config');
         if ($file) {
-            if(!file_exists($file)) {
+            if (!file_exists($file)) {
                 throw new \LogicException("the file '$file' doesn't exist");
             }
 
@@ -59,7 +58,7 @@ protected function fillTheBlanks($config)
 
     protected function getParameters()
     {
-        $parameters = array();
+        $parameters = [];
 
         foreach ($this->getDefinition()->getOptions() as $option) {
             if ($option->getName() != 'config') {
@@ -72,7 +71,7 @@ protected function getParameters()
 
     protected function getMandatoryParameters()
     {
-        return array('key', 'secret');
+        return ['key', 'secret'];
     }
 
     protected function getConfiguration(InputInterface $input)

diff --git a/src/Commands/ListCommand.php b/src/Commands/ListCommand.php
@@ -3,12 +3,10 @@
 
 use Aws\Route53\Route53Client;
 use Symfony\Component\Console\Input\InputInterface;
-use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
 
 class ListCommand extends AbstractCommand
 {
-
     protected function configure()
     {
         parent::configure();
@@ -22,17 +20,17 @@ protected function execute(InputInterface $input, OutputInterface $output)
     {
         $config = $this->getConfiguration($input);
 
-        $client = Route53Client::factory(array('key' => $config['key'], 'secret' => $config['secret']));
+        $client = Route53Client::factory(['key' => $config['key'], 'secret' => $config['secret']]);
 
         $result = $client->listHostedZones();
 
-        $content = array();
+        $content = [];
         foreach ($result['HostedZones'] as $zone) {
-            $content[] = array($zone['Name'], $zone['Id']);
+            $content[] = [$zone['Name'], $zone['Id']];
         }
 
         $table = $this->getHelperSet()->get('table');
-        $table->setHeaders(array('Name', 'ID'))->setRows($content);
+        $table->setHeaders(['Name', 'ID'])->setRows($content);
         $table->render($output);
     }
 }
diff --git a/src/Commands/UpdateCommand.php b/src/Commands/UpdateCommand.php
@@ -55,12 +55,12 @@ protected function getMandatoryParameters()
     protected function getCurrentRecord(Route53Client $client, $config)
     {
         return $client->listResourceRecordSets(
-            array(
+            [
                 'HostedZoneId' => $config['zone'],
                 'StartRecordName' => $config['domain'],
                 'StartRecordType' => 'A',
-                'MaxItems' => 1
-            )
+                'MaxItems' => 1,
+            ]
         );
     }
 
@@ -88,28 +88,28 @@ protected function needsUpdate($config, $result)
     protected function applyUpdate($client, $config)
     {
         $client->changeResourceRecordSets(
-            array(
+            [
                 // HostedZoneId is required
                 'HostedZoneId' => $config['zone'],
                 // ChangeBatch is required
-                'ChangeBatch' => array(
+                'ChangeBatch' => [
                     'Comment' => 'An IP address change was detected; updating',
                     // Changes is required
-                    'Changes' => array(
-                        array(
+                    'Changes' => [
+                        [
                             // Action is required
                             'Action' => 'UPSERT',
                             // ResourceRecordSet is required
-                            'ResourceRecordSet' => array(
+                            'ResourceRecordSet' => [
                                 'Name' => $config['domain'],
                                 'Type' => 'A',
                                 'TTL' => '60',
-                                'ResourceRecords' => array(array('Value' => $config['ip']))
-                            )
-                        )
-                    ),
-                ),
-            )
+                                'ResourceRecords' => [['Value' => $config['ip']]],
+                            ],
+                        ],
+                    ],
+                ],
+            ]
         );
     }
 
@@ -124,16 +124,16 @@ protected function execute(InputInterface $input, OutputInterface $output)
         }
 
         //open connection to R53
-        $client = Route53Client::factory(array('key' => $config['key'], 'secret' => $config['secret']));
+        $client = Route53Client::factory(['key' => $config['key'], 'secret' => $config['secret']]);
 
         $current = $this->getCurrentRecord($client, $config);
 
         if ($this->needsUpdate($config, $current)) {
             $result = $this->applyUpdate($client, $config);
 
-            $output->writeln("Updated IP to : " . $config['ip']);
+            $output->writeln('Updated IP to : ' . $config['ip']);
         } else {
-            $output->writeln("Nothing to update");
+            $output->writeln('Nothing to update');
         }
     }
 }
diff --git a/src/Compiler.php b/src/Compiler.php
@@ -21,8 +21,8 @@ class Compiler
     /**
      * Compiles composer into a single phar file
      *
-     * @throws \RuntimeException
      * @param  string $pharFile The full path to the file to create
+     * @throws \RuntimeException
      */
     public function compile($pharFile = 'dyn53.phar')
     {
@@ -124,7 +124,7 @@ private function stripWhitespace($source)
         foreach (token_get_all($source) as $token) {
             if (is_string($token)) {
                 $output .= $token;
-            } elseif (in_array($token[0], array(T_COMMENT, T_DOC_COMMENT))) {
+            } elseif (in_array($token[0], [T_COMMENT, T_DOC_COMMENT])) {
                 $output .= str_repeat("\n", substr_count($token[1], "\n"));
             } elseif (T_WHITESPACE === $token[0]) {
                 // reduce wide spaces

diff --git a/src/Policies/MyExternalIP.php b/src/Policies/MyExternalIP.php
@@ -9,7 +9,6 @@
  */
 class MyExternalIP implements ResolverPolicy
 {
-
     public function getIP()
     {
         //TODO :: use guzzle