Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to @jridgewell/resolve-uri #1

Merged
merged 1 commit into from
Aug 28, 2022

Conversation

jridgewell
Copy link

I can't push directly to your PR because it's on your main branch. Instead, here are the needed changes to switch to @jridgewell/resolve-uri package with the new relativeUri submodule.

The package isn't yet released, I'm running the following to test:

cd resolve-uri
npm install
npm run build
npm link
cd ../gen-mapping
npm link @jridgewell/resolve-uri
npm test

I'll release the new relativeUri on Mon, most likely.

@onigoetz onigoetz merged commit 851c38b into onigoetz:main Aug 28, 2022
@onigoetz
Copy link
Owner

Thanks for the PR !

I must be doing something wrong, I can't get the code working with npm link

(!) Plugin typescript: @rollup/plugin-typescript TS7016: Could not find a declaration file for module '@jridgewell/resolve-uri/relative'. '/Users/onigoetz/Sites/Libs/source-map-projects/resolve-uri/relative.js' implicitly has an 'any' type.
  If the '@jridgewell/resolve-uri' package actually exposes this module, try adding a new declaration (.d.ts) file containing `declare module '@jridgewell/resolve-uri/relative';`
src/gen-mapping.ts: (13:25)

13 import relativeUri from '@jridgewell/resolve-uri/relative';

It does seem to be using the linked version of resolve-uri, the file exists, but no types can be found.
One thing is that It seems to use relative.js which indicates that it didn't read the types from exports.
I'm using Node 16.17.0

Did you have the same issue when creating the PR ?

@jridgewell
Copy link
Author

Sorry, I forgot to push the changes to @jridgewell/resolve-uri to fix these. They're pushed now, and you should be able to test.

@jridgewell jridgewell deleted the onigoetz-main branch August 29, 2022 16:23
@onigoetz
Copy link
Owner

I does seem to work fine indeed ! I will also try it with the source-map PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants