Pyside6 package #1653
Merged
Pyside6 package #1653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@micahflee interesting that the Flatpak build is failing - it's doing so at a line where I had to recently hack to get it to work, in prep for 2.6.1. See 766df4d - you might want to revert that, maybe it's not needed anymore with your other updates here. The discussion/context for that was in #1629 |
|
I haven't looked at the Flatpak packaging yet, but I think one thing that will definitely need to be changed is to install pyside6 instead of pyside2. That patch is part of installing pyside2, so I'll see if pyside6 has less issues. |
We first get the version of tor browser and url for the platform from downloads.json. Then we get the sha256sum from the checksums provided by tor in their distribution release to compare with the file downloaded.
SaptakS
force-pushed
the
pyside6-package
branch
from
a413470
to
3e95cb9
Compare
SaptakS
force-pushed
the
pyside6-package
branch
from
3e95cb9
to
b77212c
Compare
Closed
SaptakS
force-pushed
the
pyside6-package
branch
from
a1f09a7
to
a734bbf
Compare
mig5
reviewed
Apr 24, 2023
mig5
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making a new PR for #1636 so I can test CI.